From 2fa45b92a24e76a610f86f1e039225be5d8cb695 Mon Sep 17 00:00:00 2001 From: Andrew Jorgensen Date: Thu, 12 Aug 2021 23:42:04 -0700 Subject: [PATCH] Fix a remaining issue with b8c8871 (#20) (#25) It turns out my original proposal for #20 was correct, but not for the reasons I thought. We need to set both `background-color` and `color` to `initial` on `div.highlight pre` because that's where Chroma sets those colors (including the default `color` if configured). Setting to `initial` there makes it so that if the selected style *doesn't* configure a default color, we'll use the `initial` color, which is going to be the right choice because the reason style author left that unset because they didn't consider dark color schemes messing with their style. Then we `unset` the colors on `div.highlight code` because otherwise the `code` colors from the theme will override the colors that would otherwise be inherited from Chroma's `
` element.

Stricly speaking I can't say that setting `background-color` to
`initial` is required, because I haven't found a Chroma style that
*doesn't* set a `background-color`, but I figure it's possible (at least
for a light theme) and it makes sense to fix it just in case, and causes
no harm otherwise.
---
 layouts/partials/style.html | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/layouts/partials/style.html b/layouts/partials/style.html
index 173aec9..9be0c35 100644
--- a/layouts/partials/style.html
+++ b/layouts/partials/style.html
@@ -75,9 +75,14 @@
     font-size: 14px;
   }
 
+  div.highlight pre {
+    background-color: initial;
+    color: initial;
+  }
+
   div.highlight code {
     background-color: unset;
-    color: initial;
+    color: unset;
   }
 
   blockquote {